Fix: invalid display of source files in Chrome DevTool and Firefox de… #32
Conversation
src/browser-modules/eval.js
Outdated
| sourceURL += fileName; | ||
| } | ||
|
|
||
| code = ['/*\n * File: ', fileName, '\n */\narguments[1].res=', code, '\n//# sourceURL=', sourceURL].join(''); |
There was a problem hiding this comment.
I would not do these changes in this file, because it is possible that fileName is already a full URL. It would be better to change things before in the call stack.
There was a problem hiding this comment.
To match you comment I think the best is to test the provided URL againt a location RegExp, what do you think ?
There was a problem hiding this comment.
hmm then I'm thinking again about your comment, that would be better to do it directly in AT
There was a problem hiding this comment.
@divdavem what do you think if I make the change directly in https://github.com/ariatemplates/ariatemplates/blob/master/src/aria/Aria.js#L1651 ?
With a RegExp I can check if srcURL don't match an absolute URL pattern, in that case I add the current location to the URL.
…bugger because of sourceURL format
…bugger because of sourceURL format